[ 
https://issues.apache.org/jira/browse/HBASE-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550873#comment-13550873
 ] 

stack commented on HBASE-7213:
------------------------------

I was trying this [~devaraj] and if fails to apply to trunk.  I tried to get it 
in but there is a big difference in this file: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java.rej
  Mind taking look see sir?

Looking at the patch again, you might move the define that is out in HConstants 
local to the wal package:

public static final String META_HLOG_FILE_EXTN = ".meta";  

Put it in HLog.java Interface?

In MasterFileSystem, should a few of the public methods have some javadoc or 
comment?  For instance, I see splitMetaLog twice but one takes a ServerName and 
another takes a list of ServerNames but their bodies do different things.  It 
is a little confusing.

Else looks good.  Lets get it in quick.  Elsewhere fellas are talking about 
removing MetaServerShutdown handler so would require yet another patch moving 
stuff around.  Good stuff.



                
> Have HLog files for .META. edits only
> -------------------------------------
>
>                 Key: HBASE-7213
>                 URL: https://issues.apache.org/jira/browse/HBASE-7213
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, regionserver
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 7213-2.10.patch, 7213-2.4.patch, 7213-2.6.patch, 
> 7213-2.8.patch, 7213-2.9.patch, 7213-in-progress.2.2.patch, 
> 7213-in-progress.2.patch, 7213-in-progress.patch
>
>
> Over on HBASE-6774, there is a discussion on separating out the edits for 
> .META. regions from the other regions' edits w.r.t where the edits are 
> written. This jira is to track an implementation of that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to