[ 
https://issues.apache.org/jira/browse/HBASE-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551794#comment-13551794
 ] 

Ted Yu commented on HBASE-7213:
-------------------------------

{code}
+  private static void closeWAL(final boolean delete, HLog hlog) {
     try {
-      if (this.hlog != null) {
+      if (hlog != null) {
{code}
The above code deals with hlog parameter which happens to eclipse this.hlog
It would be better to distinguish the parameter more clearly from member 
variable.

Currently HRegionServer has knowledge about the WAL for .META. and normal WAL. 
We can revisit this when multi-WAL is to be supported.
                
> Have HLog files for .META. edits only
> -------------------------------------
>
>                 Key: HBASE-7213
>                 URL: https://issues.apache.org/jira/browse/HBASE-7213
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, regionserver
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 7213-2.10.patch, 7213-2.11.patch, 7213-2.12.patch, 
> 7213-2.4.patch, 7213-2.6.patch, 7213-2.8.patch, 7213-2.9.patch, 
> 7213-in-progress.2.2.patch, 7213-in-progress.2.patch, 7213-in-progress.patch, 
> 7213v13.txt, 
> TEST-org.apache.hadoop.hbase.catalog.TestCatalogTrackerOnCluster.xml
>
>
> Over on HBASE-6774, there is a discussion on separating out the edits for 
> .META. regions from the other regions' edits w.r.t where the edits are 
> written. This jira is to track an implementation of that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to