[ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556959#comment-13556959 ]
chunhui shen commented on HBASE-7329: ------------------------------------- bq.It's the same as synchronized method It's not completely same. Suppose following scenario: Thread 1 block at synchronized (rollWriterLock) Thread 2 running rollWriter. Thread 1 will run rollWriter again after thread 2 complete it even if this.numEntries.get() <= 0. But it won't happen if synchronized method Correct me if wrong or no necessary Thanks > remove flush-related records from WAL and make locking more granular > -------------------------------------------------------------------- > > Key: HBASE-7329 > URL: https://issues.apache.org/jira/browse/HBASE-7329 > Project: HBase > Issue Type: Improvement > Components: wal > Affects Versions: 0.96.0 > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Fix For: 0.96.0 > > Attachments: 7329-findbugs.diff, HBASE-7329-v0.patch, > HBASE-7329-v0.patch, HBASE-7329-v0-tmp.patch, HBASE-7329-v1.patch, > HBASE-7329-v1.patch, HBASE-7329-v2.patch, HBASE-7329-v3.patch, > HBASE-7329-v4.patch > > > Comments from many people in HBASE-6466 and HBASE-6980 indicate that flush > records in WAL are not useful. If so, they should be removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira