[ 
https://issues.apache.org/jira/browse/HBASE-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561401#comment-13561401
 ] 

Ted Yu commented on HBASE-7638:
-------------------------------

Sergey and I looked at the patch.
There is no potential for NullPointerException similar to what HBASE-7268 
addendum fixes.
See deleteCachedLocation():
{code}
          if (oldLocation != null) {
            isStaleDelete = (source != null) && !oldLocation.equals(source);
{code}
I also ran the tests that failed in recent 0.94 builds and they all passed:

 1041  mt -Dtest=TestLruBlockCache,TestMiniClusterLoadParallel
 1042  mt -Dtest=TestLruBlockCache
 1043  mt -Dtest=TestCompactionState
 1044  mt -Dtest=TestRSKilledWhenMasterInitializing
                
> [0.94] region cache entry should only be removed on error if the error is 
> from the server currently in cache
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7638
>                 URL: https://issues.apache.org/jira/browse/HBASE-7638
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.4
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>             Fix For: 0.94.5
>
>         Attachments: HBASE-7638-v0.patch
>
>
> See HBASE-7268. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to