[ https://issues.apache.org/jira/browse/HBASE-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568807#comment-13568807 ]
Ted Yu commented on HBASE-7495: ------------------------------- Putting patch on review board would allow people to make review comments more effectively. {code} + public ThreadPoolExecutor getParallelSFSeekExecutor() { {code} The above method can be package private. {code} + private boolean parallelSFSeekEnabled; + private ThreadPoolExecutor parallelSFSeekExecutor; {code} Do you need the boolean flag ? parallelSFSeekExecutor != null would mean parallel seek enabled. {code} + public static final String STORESCANNER_PARALLEL_SEEK_ENABLE = + "hbase.storescanner.parallel.seek.enable"; {code} >From my comment above, you can see other ExecutorService specifies number of >threads. Please consider replacing the above config param with >"hbase.storescanner.parallel.seek.threads". > parallel seek in StoreScanner > ----------------------------- > > Key: HBASE-7495 > URL: https://issues.apache.org/jira/browse/HBASE-7495 > Project: HBase > Issue Type: Bug > Components: Scanners > Affects Versions: 0.94.3, 0.96.0 > Reporter: Liang Xie > Assignee: Liang Xie > Attachments: HBASE-7495.txt, HBASE-7495.txt, HBASE-7495.txt, > HBASE-7495-v2.txt, HBASE-7495-v3.txt, HBASE-7495-v4.txt, HBASE-7495-v4.txt, > HBASE-7495-v5.txt, HBASE-7495-v6.txt, HBASE-7495-v7.txt, HBASE-7495-v8.txt > > > seems there's a potential improvable space before doing scanner.next: > {code:title=StoreScanner.java|borderStyle=solid} > if (explicitColumnQuery && lazySeekEnabledGlobally) { > for (KeyValueScanner scanner : scanners) { > scanner.requestSeek(matcher.getStartKey(), false, true); > } > } else { > for (KeyValueScanner scanner : scanners) { > scanner.seek(matcher.getStartKey()); > } > } > {code} > we can do scanner.requestSeek or scanner.seek in parallel, instead of current > serialization, to reduce latency for special case. > Any ideas on it ? I'll have a try if the comments/suggestions are positive:) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira