[ 
https://issues.apache.org/jira/browse/HBASE-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571023#comment-13571023
 ] 

Anoop Sam John commented on HBASE-3787:
---------------------------------------

bq.Can you explain why you feel client does not know that the operation is 
successful in #2.
You can see the incrementColumnValue operation returns the new value of the 
column and increment() returns a Result. So in this case how we can do this? 
The 1st trial was timed out at client side and retry request is generated. At 
server then 1st trial become successful and we wont allow the second operation 
to happen but throw a OperationAlreadyCompletedException. Based on the 
exception this time reached at client it can know the operation status but can 
not know the result which it need to return to app.  This was my doubting 
point. Am I making it clear now.
                
> Increment is non-idempotent but client retries RPC
> --------------------------------------------------
>
>                 Key: HBASE-3787
>                 URL: https://issues.apache.org/jira/browse/HBASE-3787
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.96.0, 0.94.4
>            Reporter: dhruba borthakur
>            Priority: Critical
>             Fix For: 0.96.0
>
>
> The HTable.increment() operation is non-idempotent. The client retries the 
> increment RPC a few times (as specified by configuration) before throwing an 
> error to the application. This makes it possible that the same increment call 
> be applied twice at the server.
> For increment operations, is it better to use 
> HConnectionManager.getRegionServerWithoutRetries()? Another  option would be 
> to enhance the IPC module to make the RPC server correctly identify if the 
> RPC is a retry attempt and handle accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to