[
https://issues.apache.org/jira/browse/HBASE-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572239#comment-13572239
]
Jieshan Bean commented on HBASE-7750:
-------------------------------------
bq.Also on the sink side we could just print a message saying that someone
tried to replicate to us and weren't able to accept the edits.
I agree. Sink side should print this warn log.
Source side need to handle this exception, otherwise, it keeps on calling
shipEdits without sleep.
I will submit a patch after verification.
> We should throw IOE when calling HRegionServer#replicateLogEntries if
> ReplicationSink is null
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-7750
> URL: https://issues.apache.org/jira/browse/HBASE-7750
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Affects Versions: 0.96.0, 0.94.4
> Reporter: Jieshan Bean
>
> It may be an expected behavior, but I think it's better to do something.
> We configured "hbase.replication" as true in master cluster, and added peer.
> But forgot to configure "hbase.replication" on slave cluster side.
> ReplicationSource read HLog, shipped log edits, and logged position.
> Everything seemed alright. But data was not present in slave cluster.
> So I think, slave cluster should throw exception to master cluster instead of
> return directly:
> {code}
> public void replicateLogEntries(final HLog.Entry[] entries)
> throws IOException {
> checkOpen();
> if (this.replicationSinkHandler == null) return;
> this.replicationSinkHandler.replicateLogEntries(entries);
> }
> {code}
> I would like to hear your comments on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
