[ https://issues.apache.org/jira/browse/HBASE-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573720#comment-13573720 ]
Ted Yu commented on HBASE-7290: ------------------------------- ZKProcedureUtil has a reference to ZooKeeperWatcher. This reference is obtained in two places. 1. SnapshotManager ctor: {code} ProcedureCoordinatorRpcs comms = new ZKProcedureCoordinatorRpcs( master.getZooKeeper(), SnapshotManager.ONLINE_SNAPSHOT_CONTROLLER_DESCRIPTION, name); {code} 2. RegionServerSnapshotManager ctor: {code} ZooKeeperWatcher zkw = rss.getZooKeeper(); String nodeName = rss.getServerName().toString(); this.memberRpcs = new ZKProcedureMemberRpcs(zkw, SnapshotManager.ONLINE_SNAPSHOT_CONTROLLER_DESCRIPTION, nodeName); {code} This means the watcher would be closed when master / region server goes down. Looks like ZKProcedureUtil.close() doesn't have to call watcher.close() > Online snapshots > ----------------- > > Key: HBASE-7290 > URL: https://issues.apache.org/jira/browse/HBASE-7290 > Project: HBase > Issue Type: Bug > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > > HBASE-6055 will be closed when the offline snapshots pieces get merged with > trunk. This umbrella issue has all the online snapshot specific patches. > This will get merged once one of the implementations makes it into trunk. > Other flavors of online snapshots can then be done as normal patches instead > of on a development branch. (was: HBASE-6055 will be closed when the online > snapshots pieces get merged with trunk. This umbrella issue has all the > online snapshot specific patches. This will get merged once one of the > implementations makes it into trunk. Other flavors of online snapshots can > then be done as normal patches instead of on a development branch.) > (not a fan of the quick edit descirption jira feature) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira