[
https://issues.apache.org/jira/browse/HBASE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584798#comment-13584798
]
Ted Yu commented on HBASE-7824:
-------------------------------
Looks good overall.
{code}
+ // Make sure root assigned before proceeding.
+ if (!assignRoot(status)) return;
{code}
I think exception should be thrown in the above case.
{code}
+ if (failedServers != null) {
+ for (ServerName curServer : failedServers) {
{code}
The null check didn't appear ahead of the above if block. I guess the check is
not needed.
{code}
+ * Check <code>.META.</code> is assigned. If not, assign it.
+ * @throws InterruptedException
+ * @throws IOException
+ * @throws KeeperException
+ * @return Count of regions we assigned.
+ */
+ boolean assignMeta(MonitoredTask status, ServerName previousRootServer)
{code}
Please add javadoc for parameters. @return doesn't match actual return.
{code}
+ public synchronized void processDeadServer(final ServerName serverName) {
{code}
This method can be package private.
> Improve master start up time when there is log split work
> ---------------------------------------------------------
>
> Key: HBASE-7824
> URL: https://issues.apache.org/jira/browse/HBASE-7824
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Jeffrey Zhong
> Assignee: Jeffrey Zhong
> Fix For: 0.94.6
>
> Attachments: hbase-7824.patch
>
>
> When there is log split work going on, master start up waits till all log
> split work completes even though the log split has nothing to do with meta
> region servers.
> It's a bad behavior considering a master node can run when log split is
> happening while its start up is blocking by log split work.
> Since master is kind of single point of failure, we should start it ASAP.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
