[
https://issues.apache.org/jira/browse/HBASE-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593114#comment-13593114
]
Hudson commented on HBASE-7964:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #430 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/430/])
HBASE-7964 requestCompaction priority argument is not used (except for user
compaction check) (Revision 1452444)
Result = FAILURE
sershe :
Files :
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactionPolicy.java
> requestCompaction priority argument is not used (except for user compaction
> check)
> ----------------------------------------------------------------------------------
>
> Key: HBASE-7964
> URL: https://issues.apache.org/jira/browse/HBASE-7964
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7964-v0.patch, HBASE-7964-v1.patch
>
>
> In some places, like major compaction chore or requesting interface for
> coproc, we pass priority value to requestCompaction.
> Checking the code in trunk and old code in 94, I see that neither uses this
> value properly; first, they check it for being user-level. Then they do this:
> {code}
> // everything went better than expected. create a compaction request
> int pri = getCompactPriority(priority);
> ret = new CompactionRequest(region, this, filesToCompact, isMajor,
> pri);
> {code}
> getPriority does:
> {code}
> // If this is a user-requested compaction, leave this at the highest
> priority
> if(priority == PRIORITY_USER) {
> return PRIORITY_USER;
> } else {
> return this.blockingStoreFileCount - this.storefiles.size();
> }
> {code}, so non-user caller value is just thrown away. Probably if it's not
> NO_PRIORITY, it needs to be used. Overall priority code needs cleanup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
