[ https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599933#comment-13599933 ]
Anoop Sam John commented on HBASE-7801: --------------------------------------- Gone through the changes in src code 1. {code} /** + * Write the Mutation of the WAL synchronously. {code} you mean Mutation to the WAL? In other places too 2. HRegion#increment(Increment increment) {code} - syncOrDefer(txid); // sync the transaction log outside the rowlock + syncOrDefer(txid, true); // sync the transaction log outside the rowlock {code} Hard coded true. Can check whether defered sync or not? Increment is a Mutation. Will see test code part now. Patch not cleanly applying on TestRestoreFlushSnapshotFromClient.java > Allow a deferred sync option per Mutation. > ------------------------------------------ > > Key: HBASE-7801 > URL: https://issues.apache.org/jira/browse/HBASE-7801 > Project: HBase > Issue Type: Sub-task > Affects Versions: 0.95.0, 0.94.6 > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Fix For: 0.95.0, 0.98.0, 0.94.7 > > Attachments: 7801-0.94-v1.txt, 7801-0.94-v2.txt, 7801-0.94-v3.txt, > 7801-0.96-full-v2.txt, 7801-0.96-v1.txt > > > Won't have time for parent. But a deferred sync option on a per operation > basis comes up quite frequently. > In 0.96 this can be handled cleanly via protobufs and 0.94 we can have a > special mutation attribute. > For batch operation we'd take the safest sync option of any of the mutations. > I.e. if there is at least one that wants to be flushed we'd sync the batch, > if there's none of those but at least one that wants deferred flush we defer > flush the batch, etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira