[ 
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607437#comment-13607437
 ] 

Liang Xie commented on HBASE-7845:
----------------------------------

{quote}
+ @Override
+ public byte[] getFakedKey(final byte[] leftKey, final byte[] rightKey)
{ + return Arrays.copyOf(rightKey, rightKey.length); + } 
{quote}

My intention is that there is no necessary to optimize META/ROOT hfiles, of 
cause, it could be done, we can parse the special format just like 
MetaKeyComparator.compareRows impletement, but the benefit is just a bit, seems 
to me.

About perf, like HBASE-4443's description mentioned:
"when you are storing large blobs, i.e. when blocks contain small number of 
keys, and the chances of the key you are looking for being the first block of a 
key is higher."
Another benefit is reducing index size.

I thought HFilePerformanceEvaluation does not cover this scenario, probably we 
need to add a bunch of new code:)
                
> optimize hfile index key
> ------------------------
>
>                 Key: HBASE-7845
>                 URL: https://issues.apache.org/jira/browse/HBASE-7845
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>    Affects Versions: 0.96.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>             Fix For: 0.98.0
>
>         Attachments: HBASE-7845.txt, HBASE-7845-v2.txt, HBASE-7845-v3.txt, 
> HBASE-7845-v4.txt, HBASE-7845-v5.txt, HBASE-7845-v6.txt, HBASE-7845-v7.txt
>
>
> Leveldb uses ByteWiseComparatorImpl::FindShortestSeparator() & 
> FindShortSuccessor() to reduce index key size, it would be helpful under 
> special conditions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to