[ 
https://issues.apache.org/jira/browse/HBASE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609212#comment-13609212
 ] 

ramkrishna.s.vasudevan commented on HBASE-5583:
-----------------------------------------------

I am attaching a patch here with the current state of work.
This is not the final one.

Still Exception handling and testing is pending.

I would like to get myself clarified whether am going in the right direction.
My first question would be
-> In order to maintain different states at which we are in while creating 
table should we go for a special node under the table znode or can we add new 
states to the existing table states like (DISABLING, ENABLING, DISABLED etc).?

BAsed on this i can rebase the patch.
Also pls note that the ZooKeeperProto.java is showing as a complete change with 
out which this patch should be comparitively smaller.  

-> This patch basically tries to handle table creation on master failure and 
restart.
-> Adds a new state CREATINGTABLE instead of ENABLING so that we know that this 
table is partially created.
-> Adds a status node under /table to maintain various states of the table 
creation process (is this seperate node needed or not is my doubt).
-> Table lock related things needs to be checked.

Even after we do all this HBaseAdmin.isTableAvailable(tableName, splitKeys) 
should be used by the client to check if all the regions are created.  
Feed back is appreciated.
I can do more testing and handle ZK exceptions in a better way in my further 
patches.
Thanks.
                
> Master restart on create table with splitkeys does not recreate table with 
> all the splitkey regions
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5583
>                 URL: https://issues.apache.org/jira/browse/HBASE-5583
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.95.0
>
>         Attachments: HBASE-5583_new_1.patch
>
>
> -> Create table using splitkeys
> -> MAster goes down before all regions are added to meta
> -> On master restart the table is again enabled but with less number of 
> regions than specified in splitkeys
> Anyway client will get an exception if i had called sync create table.  But 
> table exists or not check will say table exists. 
> Is this scenario to be handled by client only or can we have some mechanism 
> on the master side for this? Pls suggest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to