[ 
https://issues.apache.org/jira/browse/HBASE-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609739#comment-13609739
 ] 

Ted Yu commented on HBASE-8147:
-------------------------------

nit: the JIRA number is wrong in patch filename.
{code}
+  public static class JobLaunchingOuputCommitter extends FileOutputCommitter {
{code}
The above class doesn't have to be public, right ?
{code}
+      final String table = format("%s-%s-child", NAME, context.getJobID());
{code}
Can you add comment explaining how the format string is formed ?


                
> Add Integration Test for "The HCat Scenario"
> --------------------------------------------
>
>                 Key: HBASE-8147
>                 URL: https://issues.apache.org/jira/browse/HBASE-8147
>             Project: HBase
>          Issue Type: Sub-task
>          Components: mapreduce, test
>    Affects Versions: 0.95.0, 0.98.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 
> 0001-HBASE-8174-Add-test-jobs-launched-based-on-other-job.patch, 
> HBASE-8147-WIP.patch
>
>
> HBASE-8140 needs an integration test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to