[
https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615777#comment-13615777
]
Ted Yu commented on HBASE-7615:
-------------------------------
Went through the patch which looks good.
{code}
+ new CloneSnapshotHandler(master, snapshot, hTableDescriptor,
metricsMaster).prepare();
{code}
nit: both metricsMaster and this.metricsMaster are used. It would be nice to be
consistent.
Hadoop QA is down again - may need to run test suite manually or later.
> Add metrics for snapshots
> -------------------------
>
> Key: HBASE-7615
> URL: https://issues.apache.org/jira/browse/HBASE-7615
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Matteo Bertozzi
> Attachments: HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png,
> HBASE-7615-v0-ui.png, HBASE-7615-v1.patch
>
>
> Metrics should be added for snapshot.
> From Matteo: Output that we have in SnapshotInfo should be covered:
> "%d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source
> table)"
> Jesse mentioned snaphot counts, average time to completion.
> I think we should have counts for successful / failed snapshots.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
