[ 
https://issues.apache.org/jira/browse/HBASE-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616818#comment-13616818
 ] 

Andrew Purtell commented on HBASE-8209:
---------------------------------------

bq. should there be a timeout setup in waitUntilAllRegionsAssigned in case a 
region is stuck and never been assigned?

Seems reasonable, will add.

bq. Why do you want a break instead of continue? Doesn't this drop potential 
records on the floor?

Thanks, paste-o.
This currently 'works', but in the sense of the original code I guess.

bq. Also, your non-standard for-loop control arguments caught me off-guard 

Just carried over from nearby code.
                
> Improve LoadTest extensibility
> ------------------------------
>
>                 Key: HBASE-8209
>                 URL: https://issues.apache.org/jira/browse/HBASE-8209
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.95.0, 0.96.0, 0.94.7
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>         Attachments: HBASE-8209-0.94.patch, HBASE-8209-trunk.patch
>
>
> This patch rolls up related changes:
> - Allow classes extending TestMiniClusterLoadSequential to override how 
> reader and writer threads are set up, including extending the reader and 
> writers themselves.
> - Make it so classes extending MultiThreadedWriter can cleanly override how 
> Puts are constructed.
> - Provide an option for passing in a custom table descriptor to 
> HBaseTestingUtility#createPreSplitLoadTestTable.
>     
> - HBaseTestingUtility#waitUntilAllRegionsAssigned does not check if the 
> region it is counting belongs to the table created by the test and will not 
> return if it accidentally counts "too many" regions, for example the regions 
> of the ACL table when security is enabled. (Some class based on 
> TestMiniClusterLoadSequential may want to enable security.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to