[ 
https://issues.apache.org/jira/browse/HBASE-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618165#comment-13618165
 ] 

Himanshu Vashishtha commented on HBASE-8028:
--------------------------------------------

Jimmy, Ted: Thanks for the review guys. I added a test class which has methods 
for testing rollback feature for Append and Increment.
For CFs with maxVersion = 1, the current codebase uses upserts. This patch adds 
a roll back feature for those upsert changes. For CF with maxversion > 1, it 
uses the existing rollback api.

bq. Should rollbackUpsert() return boolean to indicate whether the rollback has 
succeeded ?
It is along the line of the existing rollback api.

Incorporate the changes suggested by Ted.
                
> Append, Increment: Adding rollback support
> ------------------------------------------
>
>                 Key: HBASE-8028
>                 URL: https://issues.apache.org/jira/browse/HBASE-8028
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.94.5
>            Reporter: Himanshu Vashishtha
>            Assignee: Himanshu Vashishtha
>             Fix For: 0.95.0
>
>         Attachments: HBase-8028-v1.patch, HBase-8028-v2.patch, 
> HBase-8028-with-Increments-v1.patch, HBase-8028-with-Increments-v2.patch
>
>
> In case there is an exception while doing the log-sync, the memstore is not 
> rollbacked, while the mvcc is _always_ forwarded to the writeentry created at 
> the beginning of the operation. This may lead to scanners seeing results 
> which are not synched to the fs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to