[ https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619095#comment-13619095 ]
Hadoop QA commented on HBASE-7970: ---------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576415/HBASE-7970-v1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5082//console This message is automatically generated. > Improve file descriptor usage: currently, there are two file descriptors per > storefile > -------------------------------------------------------------------------------------- > > Key: HBASE-7970 > URL: https://issues.apache.org/jira/browse/HBASE-7970 > Project: HBase > Issue Type: Sub-task > Reporter: Himanshu Vashishtha > Assignee: Sergey Shelukhin > Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch > > > This is because there are two open calls in the HFile: one with checksum and > another for without checksum support in v2: > see the method in HFile:createReaderWithEncoding() > {code} > FSDataInputStream fsdis = fs.open(path); > FSDataInputStream fsdisNoFsChecksum = fsdis; > // If the fs is not an instance of HFileSystem, then create an > // instance of HFileSystem that wraps over the specified fs. > // In this case, we will not be able to avoid checksumming inside > // the filesystem. > if (!(fs instanceof HFileSystem)) { > hfs = new HFileSystem(fs); > } else { > hfs = (HFileSystem)fs; > // open a stream to read data without checksum verification in > // the filesystem > fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path); > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira