[ https://issues.apache.org/jira/browse/HBASE-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621391#comment-13621391 ]
Sergey Shelukhin commented on HBASE-8240: ----------------------------------------- +1 > CompoundConfiguration should implement Iterable > ----------------------------------------------- > > Key: HBASE-8240 > URL: https://issues.apache.org/jira/browse/HBASE-8240 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Ted Yu > Fix For: 0.95.1, 0.98.0 > > Attachments: 8240-v1.txt, 8240-v2.txt, 8240-v3.txt, 8240-v4.txt, > 8240-v6.txt > > > Here is from hadoop Configuration class: > {code} > public class Configuration implements Iterable<Map.Entry<String,String>>, > {code} > There're 3 addXX() methods for CompoundConfiguration: > {code} > public CompoundConfiguration add(final Configuration conf) { > public CompoundConfiguration addWritableMap( > final Map<ImmutableBytesWritable, ImmutableBytesWritable> map) { > public CompoundConfiguration addStringMap(final Map<String, String> map) { > {code} > Parameters to these methods all support iteration. > We can enhance ImmutableConfigMap with the following new method: > {code} > public abstract java.util.Iterator iterator(); > {code} > Then the following method of CompoundConfiguration can be implemented: > {code} > public Iterator<Map.Entry<String, String>> iterator() { > {code} > This enhancement would be useful in scenario where a mutable Configuration is > required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira