[ https://issues.apache.org/jira/browse/HBASE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625088#comment-13625088 ]
chunhui shen commented on HBASE-7824: ------------------------------------- Minor comments: {code}+ * @param previousRootServer ServerName of previous root region server before current start up + * @return + * @throws InterruptedException{code} remove @return {code} + } catch (Exception ex) { + LOG.warn("Retry setClusterDown failed", ex); + } {code} LOG.error seems more reasonable since using error before Some doubt: {code} + this.fileSystemManager.splitAllLogs(preRootServer); + this.fileSystemManager.splitAllLogs(preMetaServer); + fileSystemManager.splitAllLogs(currentMetaServer); {code} Should use the flag 'shouldSplitMetaSeparately' like other log-split? In master#finishInitialization, after handling other dead servers in SSH, we will call assignmentManager.joinCluster(), it seems have some problems, e.g. 1.in AssignmentManager#processDeadServersAndRegionsInTransition, how about if we mark it as a clean cluster startup? 2.if we mark it as a failover, is there any conflict between SSH and AssignmentManager#processDeadServersAndRecoverLostRegions An important attention: >From DeadServer#cleanPreviousInstance, a deadserver will be removed if the >same HostnamePort servername is online. It means a server will not belong to deadservers even if it is processed in SSH. > Improve master start up time when there is log splitting work > ------------------------------------------------------------- > > Key: HBASE-7824 > URL: https://issues.apache.org/jira/browse/HBASE-7824 > Project: HBase > Issue Type: Bug > Components: master > Reporter: Jeffrey Zhong > Assignee: Jeffrey Zhong > Fix For: 0.94.8 > > Attachments: hbase-7824.patch, hbase-7824_v2.patch, > hbase-7824_v3.patch, hbase-7824-v7.patch, hbase-7824-v8.patch, > hbase-7824-v9.patch > > > When there is log split work going on, master start up waits till all log > split work completes even though the log split has nothing to do with meta > region servers. > It's a bad behavior considering a master node can run when log split is > happening while its start up is blocking by log split work. > Since master is kind of single point of failure, we should start it ASAP. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira