[ https://issues.apache.org/jira/browse/HBASE-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625427#comment-13625427 ]
Hadoop QA commented on HBASE-8290: ---------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577528/8290.v1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5184//console This message is automatically generated. > TestHTableMultiplexer is flaky > ------------------------------ > > Key: HBASE-8290 > URL: https://issues.apache.org/jira/browse/HBASE-8290 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 0.95.0 > Reporter: Nicolas Liochon > Assignee: Nicolas Liochon > Fix For: 0.95.1 > > Attachments: 8290.v1.patch > > > I reproduce it all the time if I comment the sleep here: > {code} > private void verifyAllBufferedPutsHaveFlushed(HTableMultiplexerStatus > status) { > int retries = 8; > int tries = 0; > do { /* > try { > Thread.sleep(2 * TEST_UTIL.getConfiguration().getLong( > HTableMultiplexer.TABLE_MULTIPLEXER_FLUSH_FREQ_MS, 100)); > tries++; > } catch (InterruptedException e) { > Thread.currentThread().interrupt(); > } */ > } while (status.getTotalBufferedCounter() != 0 && tries != retries); > assertEquals("There are still some buffered puts left in the queue", > 0, status.getTotalBufferedCounter()); > } > {code} > Given that getTotalBufferedCounter is never decremented, there is a > misunderstanding somewhere. As well, reading plain values without a volatile > or a synchronized in a MT context is likely to be wrong. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira