[ https://issues.apache.org/jira/browse/HBASE-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628288#comment-13628288 ]
Lars Hofhansl commented on HBASE-7658: -------------------------------------- Looks good. Anybody concerned with backward compatibility issues? (somebody could have used empty perms before, now they'll get an exception). Just mentioning this. +1 from me, including 0.94. > grant with an empty string as permission should throw an exception > ------------------------------------------------------------------ > > Key: HBASE-7658 > URL: https://issues.apache.org/jira/browse/HBASE-7658 > Project: HBase > Issue Type: Bug > Components: security > Affects Versions: 0.95.2 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Priority: Trivial > Fix For: 0.95.1 > > Attachments: HBASE-7658-0.94.patch, HBASE-7658-v0.patch, > HBASE-7658-v1.patch > > > If someone specify an empty permission > {code}grant 'user', ''{code} > AccessControlLists.addUserPermission() output a log message and doesn't > change the permission, but the user doesn't know about it. > {code} > if ((actions == null) || (actions.length == 0)) { > LOG.warn("No actions associated with user > '"+Bytes.toString(userPerm.getUser())+"'"); > return; > } > {code} > I think we should throw an exception instead of just logging. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira