[ 
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628962#comment-13628962
 ] 

Jean-Marc Spaggiari commented on HBASE-8220:
--------------------------------------------

{code}
Tests in error: 
  testBasicRollingRestart(org.apache.hadoop.hbase.master.TestRollingRestart): 
test timed out after 300000 milliseconds

Tests run: 1335, Failures: 0, Errors: 1, Skipped: 13
{code}

I retried the failed test and it passed:

{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.master.TestRollingRestart
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 186.049 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{code}

So it seems to be good. +1 for me, even better if you can add a test.
                
> can we record the count opened HTable for HTablePool
> ----------------------------------------------------
>
>                 Key: HBASE-8220
>                 URL: https://issues.apache.org/jira/browse/HBASE-8220
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 0.94.3
>            Reporter: cuijianwei
>         Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, 
> HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, 
> HBASE-8220-0.94.3-v4.txt
>
>
> In HTablePool, we have a method getCurrentPoolSize(...) to get how many 
> opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable 
> which means the count of HTable get from HTablePool.getTable(...) and don't 
> return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may 
> be meaningful because it indicates how many HTables should be opened for the 
> application which may help us set the appropriate MaxSize of HTablePool. 
> Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to