[
https://issues.apache.org/jira/browse/HBASE-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629288#comment-13629288
]
Matteo Bertozzi commented on HBASE-7704:
----------------------------------------
the patch looks good to me,
The .archive, .snapshot doesn't contain any .tableinfo so they are not
considered in the processTable().
but if the file is a link you don't check if is v1, this means that if you've
cloned a table and removed the original one the cloned can have all v1 files
(not sure if this case exists, since snapshots are in 94 and 94 writes with v2,
but maybe there is the case that the source table of the clone was not
converted).
some other minor notes:
- Add an Example section at the end of the help, like the other tools to
demonstrate how to use it.
- could you replace the "Path p" with the different "Path tableDir", "Path
regionDir" just to make the code a little bit more readable.
> migration tool that checks presence of HFile V1 files
> -----------------------------------------------------
>
> Key: HBASE-7704
> URL: https://issues.apache.org/jira/browse/HBASE-7704
> Project: HBase
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Himanshu Vashishtha
> Priority: Blocker
> Fix For: 0.95.1
>
> Attachments: HBase-7704-v1.patch, HBase-7704-v2.patch,
> HBase-7704-v3.patch, HBase-7704-v4.patch
>
>
> Below was Stack's comment from HBASE-7660:
> Regards the migration 'tool', or 'tool' to check for presence of v1 files, I
> imagine it as an addition to the hfile tool
> http://hbase.apache.org/book.html#hfile_tool2 The hfile tool already takes a
> bunch of args including printing out meta. We could add an option to print
> out version only – or return 1 if version 1 or some such – and then do a bit
> of code to just list all hfiles and run this script against each. Could MR it
> if too many files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
