[ https://issues.apache.org/jira/browse/HBASE-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639599#comment-13639599 ]
stack commented on HBASE-7122: ------------------------------ Patch looks good. You might change this: {code} + if (this.repLogReader.getPosition() == 0 && !queueRecovered && queue.size() == 0) return true; + return false; {code} to this {code} return this.repLogReader.getPosition() == 0 && !queueRecovered && queue.size() == 0; {code} When we ask for position in the above, it is not a trip to the NN, right? > Proper warning message when opening a log file with no entries (idle cluster) > ----------------------------------------------------------------------------- > > Key: HBASE-7122 > URL: https://issues.apache.org/jira/browse/HBASE-7122 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 0.94.2 > Reporter: Himanshu Vashishtha > Assignee: Himanshu Vashishtha > Fix For: 0.95.1 > > Attachments: HBase-7122-94.patch, HBase-7122-95.patch, > HBase-7122-95-v2.patch, HBase-7122-95-v3.patch, HBase-7122.patch, > HBASE-7122.v2.patch > > > In case the cluster is idle and the log has rolled (offset to 0), > replicationSource tries to open the log and gets an EOF exception. This gets > printed after every 10 sec until an entry is inserted in it. > {code} > 2012-11-07 15:47:40,924 DEBUG regionserver.ReplicationSource > (ReplicationSource.java:openReader(487)) - Opening log for replication > c0315.hal.cloudera.com%2C40020%2C1352324202860.1352327804874 at 0 > 2012-11-07 15:47:40,926 WARN regionserver.ReplicationSource > (ReplicationSource.java:openReader(543)) - 1 Got: > java.io.EOFException > at java.io.DataInputStream.readFully(DataInputStream.java:180) > at java.io.DataInputStream.readFully(DataInputStream.java:152) > at org.apache.hadoop.io.SequenceFile$Reader.init(SequenceFile.java:1508) > at > org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1486) > at > org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1475) > at > org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1470) > at > org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader$WALReader.<init>(SequenceFileLogReader.java:55) > at > org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.init(SequenceFileLogReader.java:175) > at > org.apache.hadoop.hbase.regionserver.wal.HLog.getReader(HLog.java:716) > at > org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.openReader(ReplicationSource.java:491) > at > org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:290) > 2012-11-07 15:47:40,927 WARN regionserver.ReplicationSource > (ReplicationSource.java:openReader(547)) - Waited too long for this file, > considering dumping > 2012-11-07 15:47:40,927 DEBUG regionserver.ReplicationSource > (ReplicationSource.java:sleepForRetries(562)) - Unable to open a reader, > sleeping 1000 times 10 > {code} > We should reduce the log spewing in this case (or some informative message, > based on the offset). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira