[ https://issues.apache.org/jira/browse/HBASE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652099#comment-13652099 ]
Hadoop QA commented on HBASE-1762: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12582312/1762v3.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 5 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5593//console This message is automatically generated. > Remove concept of ZooKeeper from HConnection interface > ------------------------------------------------------ > > Key: HBASE-1762 > URL: https://issues.apache.org/jira/browse/HBASE-1762 > Project: HBase > Issue Type: Improvement > Components: Client > Affects Versions: 0.20.0 > Reporter: Ken Weiner > Assignee: stack > Fix For: 0.95.1 > > Attachments: 1762v2.txt, 1762v3.txt, 1762v3.txt, HBASE-1762.patch > > > The concept of ZooKeeper is really an implementation detail and should not be > exposed in the {{HConnection}} interface. Therefore, I suggest removing the > {{HConnection.getZooKeeperWrapper()}} method from the interface. > I couldn't find any uses of this method within the HBase code base except for > in one of the unit tests: {{org.apache.hadoop.hbase.TestZooKeeper}}. This > unit test should be changed to instantiate the implementation of > {{HConnection}} directly, allowing it to use the {{getZooKeeperWrapper()}} > method. This requires making > {{org.apache.hadoop.hbase.client.HConnectionManager.TableServers}} public. > (I actually think TableServers should be moved out into an outer class, but > in the spirit of small patches, I'll refrain from suggesting that in this > issue). > I'll attach a patch for: > # The removal of {{HConnection.getZooKeeperWrapper()}} > # Change of {{TableServers}} class from private to public > # Direct instantiation of {{TableServers}} within {{TestZooKeeper}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira