[ 
https://issues.apache.org/jira/browse/HBASE-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse Yates updated HBASE-8355:
-------------------------------

      Resolution: Fixed
    Release Note: 
As pointed out in https://github.com/forcedotcom/phoenix/pull/131, 
BaseRegionObserver#preCompactScannerOpen returns null by default, which hoses 
any coprocessors down the line, making override of this method mandatory in all 
subclasses of BaseRegionObserver, when there are multiple levels of coprocessor 
stacking - this same behavior is present in preFlushScannerOpen and 
preStoreScannerOpen. 

Instead, we default to returning the passed scanner so earlier coprocessor 
changes are preserved and still support the default "no custom scanner" by 
returning null (default scanner passed to each hook).
          Status: Resolved  (was: Patch Available)
    
> BaseRegionObserver#pre(Compact|Flush|Store)ScannerOpen returns null
> -------------------------------------------------------------------
>
>                 Key: HBASE-8355
>                 URL: https://issues.apache.org/jira/browse/HBASE-8355
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.98.0, 0.94.8, 0.95.1
>            Reporter: Andrew Purtell
>            Assignee: Jesse Yates
>         Attachments: 8355-0.94.patch, 8355.patch, hbase-8355-0.94-v0.patch, 
> hbase-8355-trunk-v0.patch, hbase-8355-trunk-v1.patch
>
>
> As pointed out in https://github.com/forcedotcom/phoenix/pull/131, 
> BaseRegionObserver#preCompactScannerOpen returns null by default, which hoses 
> any coprocessors down the line, making override of this method mandatory. The 
> fix is trivial, patch coming momentarily.
> Update:
> This same behavior is present in the Flush and Store versions of the same 
> method - this should all be moved to the proposed 'return passed scanner' 
> default behavior.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to