[
https://issues.apache.org/jira/browse/HBASE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660497#comment-13660497
]
Ivan A. Veselovsky commented on HBASE-8553:
-------------------------------------------
??Is the patch relevant for trunk as well or is this because the backport
didn't include the tests???
no, the patch is not relevant for trunk because the classes with poor coverage
("org/apache/hadoop/hbase/mapreduce/hadoopbackport/{InputSampler.java,TotalOrderPartitioner.java}")
do exist only in branch 0.94.
In branch "0.95" and "trunk" the package
"org/apache/hadoop/hbase/mapreduce/hadoopbackport/" contains only 1 class
JarFinder which is covered well.
??Does this fix a real issue or not:??
Yes, this is real issue because it makes impossible to set the output file name
for the tool (the corresponding parameter is not used, and the default output
file name is used instead).
??Should we pick the tests from hadoop trunk instead of 0.23???
I suppose, no, because the tests from 0.23 better fit the code of the classes
.../hadoopbackport/{InputSampler.java,TotalOrderPartitioner.java}.
> improve unit-test coverage of package
> org.apache.hadoop.hbase.mapreduce.hadoopbackport
> --------------------------------------------------------------------------------------
>
> Key: HBASE-8553
> URL: https://issues.apache.org/jira/browse/HBASE-8553
> Project: HBase
> Issue Type: Test
> Affects Versions: 0.94.9
> Reporter: Ivan A. Veselovsky
> Attachments: HBASE-8553-0.94--N2.patch
>
>
> The patch is for branch 0.94 only.
> The class InputSampler is modified because need to fix bug there: in method
> "run(String[] args)" should be
> "TotalOrderPartitioner.setPartitionFile(job.getConfiguration(), outf);"
> instead of "TotalOrderPartitioner.setPartitionFile(getConf(), outf);".
> Otherwise it is impossible to set output file correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
