[ https://issues.apache.org/jira/browse/HBASE-8539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660970#comment-13660970 ]
Hadoop QA commented on HBASE-8539: ---------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12583674/hbase-8539-addendum-04.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5741//console This message is automatically generated. > Double(or tripple ...) ZooKeeper listeners of the same type when Master > recovers from ZK SessionExpiredException > ---------------------------------------------------------------------------------------------------------------- > > Key: HBASE-8539 > URL: https://issues.apache.org/jira/browse/HBASE-8539 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 0.98.0, 0.94.7, 0.95.0 > Reporter: Jeffrey Zhong > Assignee: Jeffrey Zhong > Fix For: 0.98.0, 0.94.8, 0.95.1 > > Attachments: 8539-addendum-v2.patch, double-registered listeners.png, > hbase-8539-0.94-addendum-03.patch, hbase-8539-0.94-addendum-04.patch, > hbase-8539-0.94.patch, hbase-8539-addendum-03.patch, > hbase-8539-addendum-04.patch, hbase-8539.patch, hbase-8539.patch > > > When Master tries to recover from zookeeper session expired exceptions, we > don't clean old registered listener instances. Therefore, it may end up we > have two(or more) listeners to double handling same events. Attached a screen > shot from debugger to show the issue. > I considered to limit one listener per class while I think that would limit > the listener usage so I choose to clear exiting listeners during recovery for > the fix. > (This issue is unrelated to the issue HBASE-8365 because I verified there is > no dup-listeners when HBASE-8365 happened) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira