[ 
https://issues.apache.org/jira/browse/HBASE-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661053#comment-13661053
 ] 

Jonathan Hsieh commented on HBASE-8461:
---------------------------------------

Hey guys, just saw this. I'm concerned about this for delete and actually 
thinking about that also concerned about the list method.

ex:
{code} 
// API call 
deleteSnapshots(".*")
{code}

This will delete all snapshots.   (not just those starting with '.').  If 
people thing of these as file regexes instead of java regexes they might delete 
things, especially if there is no ability to do a confirmation.

I also don't think we should widen the hbase admin api for this.  Why not just 
have this in the jruby shell like this[1]?  We do similar things for listing 
and removing tables there and with deleting tables we have the enable/disable 
safeguard.

[1] 
https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/ruby/shell/commands/list.rb

                
> Provide the ability to delete multiple snapshots through single command
> -----------------------------------------------------------------------
>
>                 Key: HBASE-8461
>                 URL: https://issues.apache.org/jira/browse/HBASE-8461
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: 8461-v1.txt, 8461-v2.txt, 8461-v3.txt, 8461-v4.txt
>
>
> Currently HBaseAdmin#deleteSnapshot() accepts name of single snapshot.
> It is desirable to allow user to delete multiple snapshots by issuing one 
> command.
> e.g. user may use regular expression to specify the names of snapshots to 
> delete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to