[
https://issues.apache.org/jira/browse/HBASE-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667788#comment-13667788
]
Ted Yu commented on HBASE-8534:
-------------------------------
{code}
+@Category(LargeTests.class)
+public class TestExamples {
{code}
Would TestMapReduceExamples be better name for the class ?
In testCellCounter(),
{code}
+ HTable t = UTIL.createTable(Bytes.toBytes(sourceTable), families);
{code}
Please close t at the end of the test.
{code}
+ * Test main method of CellCounter
+ */
+ @Test
+ public void testMain() throws Exception {
{code}
Name the above testCellCounterMain ?
{code}
+ .contains(
+ "Usage: CellCounter <tablename> <outputDir> <reportSeparator>
[^[regex pattern]" +
+ " or [Prefix] for row filter]]"));
{code}
What if new parameter is added to CellCounter in the future ?
{code}
+public class TestCopy {
{code}
Name the class TestCopyTable.
{code}
+ .contains(
+ "Usage: CopyTable [general options] [--starttime=X] [--endtime=Y]
[--new.name=NEW]" +
+ " [--peer.adr=ADR] <tablename>"));
{code}
Similar to previous comment: this is not prepared for future enhancement -
startRow and stopRow are being added to CopyTable (HBASE-8609).
> fix coverage org.apache.hadoop.hbase.mapreduce
> ----------------------------------------------
>
> Key: HBASE-8534
> URL: https://issues.apache.org/jira/browse/HBASE-8534
> Project: HBase
> Issue Type: Test
> Affects Versions: 0.94.8, 0.95.2
> Reporter: Aleksey Gorshkov
> Attachments: HBASE-8534-0.94.patch, HBASE-8534-trunk-a.patch,
> HBASE-8534-trunk-b.patch, HBASE-8534-trunk-c.patch, HBASE-8534-trunk.patch
>
>
> fix coverage org.apache.hadoop.hbase.mapreduce
> patch HBASE-8534-0.94.patch for branch-0.94
> patch HBASE-8534-trunk.patch for branch-0.95 and trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
