[
https://issues.apache.org/jira/browse/HBASE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670426#comment-13670426
]
Matteo Bertozzi commented on HBASE-8642:
----------------------------------------
{quote}Another question is that why not define more functions in admin module
pointing to e.g. HBaseAdmin#listSnapshots(regex), #deleteSnapshots(regex)..
then shell/command/*.rb module could invoke them directly, currently,
list_snapshots module has its own regex processing logic implemented?
"xxx.to_java_bytes" is mandatory for ruby->java method call?{quote}
No particular reason, the admin.listSnapshots(regex) & co were added later, and
the shell was not updated to use them. and since the regex stuff is just a loop
with an if there's no real advantage of having it in the admin, aside saving
you from write 3 extra lines of code.
Jon was suggesting to have extra logic in the shell for stuff like delete with
regex, where you may want to add an "are you sure?" check in front.
> [Snapshot] List and delete snapshot by table
> --------------------------------------------
>
> Key: HBASE-8642
> URL: https://issues.apache.org/jira/browse/HBASE-8642
> Project: HBase
> Issue Type: Improvement
> Components: snapshots
> Affects Versions: 0.98.0, 0.95.0, 0.95.1, 0.95.2
> Reporter: Julian Zhou
> Assignee: Julian Zhou
> Priority: Minor
> Fix For: 0.98.0, 0.95.0, 0.95.1, 0.95.2
>
> Attachments: 8642-trunk-0.95-v0.patch
>
>
> Support list and delete snapshot by table name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
