[ 
https://issues.apache.org/jira/browse/HIVE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357403#comment-14357403
 ] 

Brock Noland commented on HIVE-9914:
------------------------------------

bq. patch_contains_hms_upgrade {

I think this function can be simplified to:

{noformat}
local patch_file=$(mktemp /tmp/tmp.XXXXXX) # note this template is required on 
centos
trap EXIT "rm -f $patch_file"
wget "$1" -O $patch_file || return 1
grep "^diff.*metastore/scripts/upgrade/"
{noformat}


bq. java -cp "hive/build/ptest2/target/hive-ptest-1.0-classes.jar"

I think that this can be {{java -cp "hive/build/ptest2/target/*"}} so we don't 
store the version number?

> Post success comments on Jira from Jenkins metastore upgrades scripts
> ---------------------------------------------------------------------
>
>                 Key: HIVE-9914
>                 URL: https://issues.apache.org/jira/browse/HIVE-9914
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Sergio Peña
>            Assignee: Sergio Peña
>         Attachments: HIVE-9914.1.patch
>
>
> Currently, the HMS upgrade testing post failure comments on Jira only. We 
> need to post success comments as well so that users know that their upgrade 
> changes are working.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to