[
https://issues.apache.org/jira/browse/HIVE-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360408#comment-14360408
]
Xuefu Zhang commented on HIVE-9956:
-----------------------------------
+1
> use BigDecimal.valueOf instead of new in TestFileDump
> -----------------------------------------------------
>
> Key: HIVE-9956
> URL: https://issues.apache.org/jira/browse/HIVE-9956
> Project: Hive
> Issue Type: Bug
> Components: File Formats
> Reporter: Alexander Pivovarov
> Assignee: Alexander Pivovarov
> Priority: Minor
> Attachments: HIVE-9956.1.patch
>
>
> TestFileDump builds data row where one of the column is BigDecimal
> The test adds value 2.2222
> There are 2 ways to create BigDecimal object.
> 1. use new
> 2. use valueOf
> in this particular case
> 1. "new" will create 2.222199999999999953
> 2. valueOf will use the canonical String representation and the result will
> be 2.2222
> Probably we should use valueOf to create BigDecimal object
> TestTimestampWritable and TestHCatStores use valueOf
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
