[ https://issues.apache.org/jira/browse/HIVE-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487603#comment-14487603 ]
Alan Gates commented on HIVE-6108: ---------------------------------- Ok, so this review is way overdue, but better late than never A few issues # You should consider using GenericUDF rather than UDF, see the comments in those classes on why. # When errors are encountered in the code it should write to the log rather than System.out. See many places in the Hive code for examples. # We cannot have any System.exit calls in the code. Some of this code runs in servers that cannot exit. Exceptions should be thrown instead. > Introduce Cryptographic hash UDFs > --------------------------------- > > Key: HIVE-6108 > URL: https://issues.apache.org/jira/browse/HIVE-6108 > Project: Hive > Issue Type: New Feature > Components: UDF > Reporter: Kostiantyn Kudriavtsev > Assignee: Kostiantyn Kudriavtsev > Priority: Minor > Attachments: Hive-6108.patch > > > Introduce new UDF to implement Cryptographic hash algorithms: MD5 and SHA-256 > which is already available in Java: > MD5(string) Calculates an MD5 checksum for the string, return HEX > representation > SHA256(string) Calculates an SHA-256 checksum for the string, return HEX > representation -- This message was sent by Atlassian JIRA (v6.3.4#6332)