[ 
https://issues.apache.org/jira/browse/HIVE-10305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490867#comment-14490867
 ] 

Prasanth Jayachandran commented on HIVE-10305:
----------------------------------------------

LGTM, +1

> TestOrcFile has a mistake that makes metadata test ineffective
> --------------------------------------------------------------
>
>                 Key: HIVE-10305
>                 URL: https://issues.apache.org/jira/browse/HIVE-10305
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: HIVE-10305.patch
>
>
> Two of the values that are being stored as user metadata in 
> TestOrcFile.metaData weren't flipped and thus were empty buffers. The test 
> passes because they are compared to empty buffers. We should fix the test to 
> perform the expected test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to