[ https://issues.apache.org/jira/browse/HIVE-9605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557665#comment-14557665 ]
Hive QA commented on HIVE-9605: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12735048/HIVE-9605.6.patch {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 8973 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_crc32 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_sha1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vector_join30 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vector_null_projection {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4027/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4027/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4027/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12735048 - PreCommit-HIVE-TRUNK-Build > Remove parquet nested objects from wrapper writable objects > ----------------------------------------------------------- > > Key: HIVE-9605 > URL: https://issues.apache.org/jira/browse/HIVE-9605 > Project: Hive > Issue Type: Sub-task > Affects Versions: 0.14.0 > Reporter: Sergio Peña > Assignee: Sergio Peña > Fix For: parquet-branch > > Attachments: HIVE-9605.3.patch, HIVE-9605.4.patch, HIVE-9605.5.patch, > HIVE-9605.6.patch > > > Parquet nested types are using an extra wrapper object (ArrayWritable) as a > wrapper of map and list elements. This extra object is not needed and causing > unnecessary memory allocations. > An example of code is on HiveCollectionConverter.java: > {noformat} > public void end() { > parent.set(index, wrapList(new ArrayWritable( > Writable.class, list.toArray(new Writable[list.size()])))); > } > {noformat} > This object is later unwrapped on AbstractParquetMapInspector, i.e.: > {noformat} > final Writable[] mapContainer = ((ArrayWritable) data).get(); > final Writable[] mapArray = ((ArrayWritable) mapContainer[0]).get(); > for (final Writable obj : mapArray) { > ... > } > {noformat} > We should get rid of this wrapper object to save time and memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)