[ 
https://issues.apache.org/jira/browse/HIVE-18367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320188#comment-16320188
 ] 

Peter Vary commented on HIVE-18367:
-----------------------------------

Hi [~asherman],
My concern is, that previously we had extra lines in the q.out files which were 
checked by the tests:
{code}
#### A masked pattern was here ####
FROM table1, viewExpandedText:SELECT `_c0` AS `c` FROM (SELECT 
`test_translate`('abc', 'a', 'b')                                
FROM `default`.`table1`) `default.view8`, tableType:VIRTUAL_VIEW, 
rewriteEnabled:false) 
{code}
Which is changed to this:
{code}
#### A masked pattern was here ####
{code}
Basically this means that the previous checks at least checked that the select 
was contained in the description of the view (however imperfectly :) ), but 
after the patch this is not checked at all because of the masking of the q.out 
files.
However this can be a follow-up jira to add some tests to check that the table 
information contains the query correctly.

+1

> Describe Extended output is truncated on a table with an explicit row format 
> containing tabs or newlines.
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-18367
>                 URL: https://issues.apache.org/jira/browse/HIVE-18367
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Andrew Sherman
>            Assignee: Andrew Sherman
>         Attachments: HIVE-18367.1.patch, HIVE-18367.2.patch, 
> HIVE-18367.3.patch
>
>
> 'Describe Extended' dumps information about a table. The protocol for sending 
> this data relies on tabs and newlines to separate pieces of data. If a table 
> has 'FIELDS terminated by XXX' or 'LINES terminated by XXX' where XXX is a 
> tab or newline then the output seen by the user is prematurely truncated. Fix 
> this by replacing tabs and newlines in the table description with “\n” and 
> “\t”.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to