[ 
https://issues.apache.org/jira/browse/HIVE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332119#comment-16332119
 ] 

Zoltan Haindrich commented on HIVE-18061:
-----------------------------------------

The code changes look good :)
It's great that now: 
ql/src/test/results/clientnegative/alter_table_wrong_location.q.out and many 
other negative tests has the exception type/etc recorded in the q.out!
I hope that the "appeared resultsets" which were hidden earlier not cause any 
problems...
and now dfs -ls has its output recorded - same for this :)
the patch contains unrelated changes: for example: 
ql/src/test/results/clientpositive/llap/sysdb.q.out
and there are some new files which ends with {{out_spark}}; for example: 
{{ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out_spark}} 
I don't they are needed...

> q.outs: be more selective with masking hdfs paths
> -------------------------------------------------
>
>                 Key: HIVE-18061
>                 URL: https://issues.apache.org/jira/browse/HIVE-18061
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Laszlo Bodor
>            Priority: Major
>         Attachments: HIVE-18061.01.patch, HIVE-18061.02.patch, 
> HIVE-18061.03.patch, HIVE-18061.04.patch, HIVE-18061.05.patch, 
> HIVE-18061.06.patch, HIVE-18061.07.patch, HIVE-18061.08.patch, 
> HIVE-18061.09.patch, HIVE-18061.10.patch, HIVE-18061.11.patch, 
> HIVE-18061.12.patch, HIVE-18061.13.patch
>
>
> currently any line which contains a path which looks like an hdfs location is 
> replaced with a "masked pattern was here"...
> it might be releavant to record these messages; since even an exception 
> message might contain an hdfs location
> noticed in
> HIVE-18012



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to