[
https://issues.apache.org/jira/browse/HIVE-18222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Haindrich updated HIVE-18222:
------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Status: Resolved (was: Patch Available)
pushed to master. Thank you Ashutosh for reviewing the changes!
I've reduced the max line length to 120; (the discussion thread have
halted)...but because there are other changes in this ticket which may help; I
would not like to hold it back anymore.
> Update checkstyle rules to be less peeky
> ----------------------------------------
>
> Key: HIVE-18222
> URL: https://issues.apache.org/jira/browse/HIVE-18222
> Project: Hive
> Issue Type: Sub-task
> Components: Tests
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HIVE-18222.01.patch
>
>
> there are a few issues with the current checkstyle.xml
> as long as the new checks are coming back red all the time; people will start
> to ignore these checks...so I think, it would be better to make the checks
> less strict...
> * set max linelength to 140; it looks like a more natural limit - because
> there are classnames which are eating up line space pretty quickly... like:
> {{PrimitiveObjectInspector}} :)
> * make checkstyle.xml easily importable into ide (use {{config_loc}} instead
> {{basedir}})
> * suppress generated vectorized class errors
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
