[ 
https://issues.apache.org/jira/browse/HIVE-18192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333553#comment-16333553
 ] 

Hive QA commented on HIVE-18192:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12907005/HIVE-18192.03.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8738/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8738/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8738/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-01-21 15:04:14.083
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-8738/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-01-21 15:04:14.086
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 90d236a HIVE-18231 : validate resource plan - part 2 - validate 
action and trigger expressions (Harish Jaiprakash, reviewed by Sergey Shelukhin)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 90d236a HIVE-18231 : validate resource plan - part 2 - validate 
action and trigger expressions (Harish Jaiprakash, reviewed by Sergey Shelukhin)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-01-21 15:04:14.603
+ rm -rf ../yetus
+ mkdir ../yetus
+ git gc
+ cp -R . ../yetus
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-8738/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
fatal: git apply: bad git-diff - inconsistent old filename on line 48126
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp:1240
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp' with 
conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp:23884
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp' with 
conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java:34145
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java:346
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java:376
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php:12984
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php' 
with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php:23418
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php' with 
conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py:13638
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py'
 with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py:16562
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py' with 
conflicts.
Going to apply patch with: git apply -p1
/data/hiveptest/working/scratch/build.patch:18805: trailing whitespace.
    tmpMap.put(_Fields.DB_NAME, new 
org.apache.thrift.meta_data.FieldMetaData("dbName", 
org.apache.thrift.TFieldRequirementType.REQUIRED, 
/data/hiveptest/working/scratch/build.patch:18807: trailing whitespace.
    tmpMap.put(_Fields.TABLE_NAME, new 
org.apache.thrift.meta_data.FieldMetaData("tableName", 
org.apache.thrift.TFieldRequirementType.REQUIRED, 
/data/hiveptest/working/scratch/build.patch:19102: trailing whitespace.
        if (schemeField.type == org.apache.thrift.protocol.TType.STOP) { 
/data/hiveptest/working/scratch/build.patch:19110: trailing whitespace.
            } else { 
/data/hiveptest/working/scratch/build.patch:19118: trailing whitespace.
            } else { 
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp:1240
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp' with 
conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp:23884
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp' with 
conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java:34145
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java:346
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java:376
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php:12984
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php' 
with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php:23418
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php' with 
conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py:13638
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py'
 with conflicts.
error: patch failed: 
standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py:16562
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py' with 
conflicts.
U standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp
U standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp
U 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
U 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java
U 
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java
U standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php
U standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php
U 
standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
U standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py
warning: squelched 87 whitespace errors
warning: 92 lines add whitespace errors.
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12907005 - PreCommit-HIVE-Build

> Introduce WriteID per table rather than using global transaction ID
> -------------------------------------------------------------------
>
>                 Key: HIVE-18192
>                 URL: https://issues.apache.org/jira/browse/HIVE-18192
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HiveServer2, Transactions
>    Affects Versions: 3.0.0
>            Reporter: anishek
>            Assignee: Sankar Hariappan
>            Priority: Major
>              Labels: ACID, DR, pull-request-available
>             Fix For: 3.0.0
>
>         Attachments: HIVE-18192.01.patch, HIVE-18192.02.patch, 
> HIVE-18192.03.patch
>
>
> To support ACID replication, we will be introducing a per table write Id 
> which will replace the transaction id in the primary key for each row in a 
> ACID table.
> The current primary key is determined via 
>  <original transaction id, bucketid , rowid>
> which will move to 
>  <original write id, bucketid, rowid>
> For each table modified by the given transaction will have a table level 
> write ID allocated and a persisted map of global txn id -> to table -> write 
> id for that table has to be maintained to allow Snapshot isolation.
> Readers should use the combination of ValidTxnList and 
> ValidWriteIdList(Table) for snapshot isolation.
>  
>  [Hive Replication - ACID 
> Tables.pdf|https://issues.apache.org/jira/secure/attachment/12903157/Hive%20Replication-%20ACID%20Tables.pdf]
>  has a section "Per Table Sequences (Write-Id)" with more detials



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to