[ https://issues.apache.org/jira/browse/HIVE-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Szita updated HIVE-18554: ------------------------------ Attachment: HIVE-18554.0.patch > Fix false positive test ql.io.parquet.TestHiveSchemaConverter.testMap > ---------------------------------------------------------------------- > > Key: HIVE-18554 > URL: https://issues.apache.org/jira/browse/HIVE-18554 > Project: Hive > Issue Type: Bug > Reporter: Adam Szita > Assignee: Adam Szita > Priority: Major > Attachments: HIVE-18554.0.patch > > > In test case {{testMap}} the AssertEquals check was returning a false > positive result, due to a Parquet bug: > Original types were not asserted in equals method, this has been fixed here: > [https://github.com/apache/parquet-mr/commit/878ebcd0bc2592fa9d5dda01117c07bc3c40bb33] > What this test would produce after the Parquet fix is this: > {code:java} > expected:<message hive_schema { > optional group mapCol (MAP) { > repeated group map (MAP_KEY_VALUE) { > required binary key; > optional binary value; > } > } > } > > but was:<message hive_schema { > optional group mapCol (MAP) { > repeated group map (MAP_KEY_VALUE) { > required binary key (UTF8); > optional binary value (UTF8); > } > } > } > >{code} > Once we upgrade to a Parquet lib with this fix in place our test case will > produce failure too, hence I propose fixing it now. -- This message was sent by Atlassian JIRA (v7.6.3#76005)