[ https://issues.apache.org/jira/browse/HIVE-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342281#comment-16342281 ]
Hive QA commented on HIVE-18554: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12907846/HIVE-18554.0.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 11838 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries] (batchId=240) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2] (batchId=49) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook] (batchId=13) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=78) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1] (batchId=172) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=161) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan] (batchId=164) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=161) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_input_format_excludes] (batchId=163) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5] (batchId=122) org.apache.hadoop.hive.ql.exec.TestOperators.testNoConditionalTaskSizeForLlap (batchId=282) org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=256) org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188) org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=234) org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=234) org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=234) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8874/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8874/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8874/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 20 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12907846 - PreCommit-HIVE-Build > Fix false positive test ql.io.parquet.TestHiveSchemaConverter.testMap > ---------------------------------------------------------------------- > > Key: HIVE-18554 > URL: https://issues.apache.org/jira/browse/HIVE-18554 > Project: Hive > Issue Type: Bug > Reporter: Adam Szita > Assignee: Adam Szita > Priority: Major > Attachments: HIVE-18554.0.patch > > > In test case {{testMap}} the AssertEquals check was returning a false > positive result, due to a Parquet bug: > Original types were not asserted in equals method, this has been fixed here: > [https://github.com/apache/parquet-mr/commit/878ebcd0bc2592fa9d5dda01117c07bc3c40bb33] > What this test would produce after the Parquet fix is this: > {code:java} > expected:<message hive_schema { > optional group mapCol (MAP) { > repeated group map (MAP_KEY_VALUE) { > required binary key; > optional binary value; > } > } > } > > but was:<message hive_schema { > optional group mapCol (MAP) { > repeated group map (MAP_KEY_VALUE) { > required binary key (UTF8); > optional binary value (UTF8); > } > } > } > >{code} > It affects testMapDecimal test case similarly. > Once we upgrade to a Parquet lib with this fix in place our test case will > produce failure too, hence I propose fixing it now. -- This message was sent by Atlassian JIRA (v7.6.3#76005)