[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357384#comment-16357384 ]
Hive QA commented on HIVE-18359: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12909703/HIVE-18359.11.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9098/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9098/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9098/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-02-08 18:41:33.061 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-9098/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-02-08 18:41:33.067 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at b8fdd13 HIVE-18511: Fix generated checkstyle errors (Peter Vary, reviewed by Yongzhi Chen) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at b8fdd13 HIVE-18511: Fix generated checkstyle errors (Peter Vary, reviewed by Yongzhi Chen) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-02-08 18:41:35.773 + rm -rf ../yetus + mkdir ../yetus + git gc + cp -R . ../yetus + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9098/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java: does not exist in index error: a/ql/src/test/queries/clientpositive/cte_1.q: does not exist in index error: a/ql/src/test/results/clientpositive/annotate_stats_groupby.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_cube1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_id3.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_grouping_window.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_rollup1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/groupby_rollup_empty.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/limit_pushdown2.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/cte_1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/llap_acid.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/llap_acid_fast.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query18.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query22.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query27.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query36.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query5.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query67.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query70.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query77.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query80.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/perf/spark/query86.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/spark/groupby_cube1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/vector_grouping_sets.q.out: does not exist in index error: a/ql/src/test/results/clientpositive/view_cbo.q.out: does not exist in index error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:2963 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java' with conflicts. Going to apply patch with: git apply -p1 /data/hiveptest/working/scratch/build.patch:701: trailing whitespace. select /data/hiveptest/working/scratch/build.patch:797: trailing whitespace. select /data/hiveptest/working/scratch/build.patch:901: trailing whitespace. select /data/hiveptest/working/scratch/build.patch:1013: trailing whitespace. create table groupingsets32 as /data/hiveptest/working/scratch/build.patch:1014: trailing whitespace. select error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:2963 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java' with conflicts. U ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java warning: squelched 282 whitespace errors warning: 287 lines add whitespace errors. + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12909703 - PreCommit-HIVE-Build > Extend grouping set limits from int to long > ------------------------------------------- > > Key: HIVE-18359 > URL: https://issues.apache.org/jira/browse/HIVE-18359 > Project: Hive > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Prasanth Jayachandran > Assignee: Prasanth Jayachandran > Priority: Major > Attachments: HIVE-18359.1.patch, HIVE-18359.10.patch, > HIVE-18359.11.patch, HIVE-18359.2.patch, HIVE-18359.3.patch, > HIVE-18359.4.patch, HIVE-18359.5.patch, HIVE-18359.6.patch, > HIVE-18359.7.patch, HIVE-18359.8.patch, HIVE-18359.9.patch > > > Grouping sets is broken for >32 columns because of usage of Int for bitmap > (also GROUPING__ID virtual column). This assumption breaks grouping > sets/rollups/cube when number of participating aggregation columns is >32. > The easier fix would be extend it to Long for now. The correct fix would be > to use BitSets everywhere but that would require GROUPING__ID column type to > binary which will make predicates on GROUPING__ID difficult to deal with. -- This message was sent by Atlassian JIRA (v7.6.3#76005)