[
https://issues.apache.org/jira/browse/HIVE-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366031#comment-16366031
]
Hive QA commented on HIVE-18622:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12910715/HIVE-18622.099.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9234/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9234/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9234/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-02-15 17:58:06.257
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-9234/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-02-15 17:58:06.260
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 974d419 HIVE-18421 : Vectorized execution handles overflows in a
different manner than non-vectorized execution (Vihang Karajgaonkar, reviewed
by Sahil Takiar)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 974d419 HIVE-18421 : Vectorized execution handles overflows in a
different manner than non-vectorized execution (Vihang Karajgaonkar, reviewed
by Sahil Takiar)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-02-15 17:58:09.679
+ rm -rf ../yetus
+ mkdir ../yetus
+ git gc
+ cp -R . ../yetus
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9234/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt:122
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt' with
conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalar.txt:15
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalar.txt' with
conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt:15
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt' with
conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/ScalarArithmeticColumn.txt:74
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/ScalarArithmeticColumn.txt'
cleanly.
Going to apply patch with: git apply -p0
/data/hiveptest/working/scratch/build.patch:16494: trailing whitespace.
*/
/data/hiveptest/working/scratch/build.patch:16836: trailing whitespace.
*/
/data/hiveptest/working/scratch/build.patch:22330: trailing whitespace.
}
/data/hiveptest/working/scratch/build.patch:22338: trailing whitespace.
/data/hiveptest/working/scratch/build.patch:22402: trailing whitespace.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt:122
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt' with
conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalar.txt:15
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalar.txt' with
conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt:15
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt' with
conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/ScalarArithmeticColumn.txt:74
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/ScalarArithmeticColumn.txt'
cleanly.
U ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt
U ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalar.txt
U ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt
warning: squelched 260 whitespace errors
warning: 265 lines add whitespace errors.
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12910715 - PreCommit-HIVE-Build
> Vectorization: IF Statements, Comparisons, and more do not handle NULLs
> correctly
> ---------------------------------------------------------------------------------
>
> Key: HIVE-18622
> URL: https://issues.apache.org/jira/browse/HIVE-18622
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HIVE-18622.03.patch, HIVE-18622.04.patch,
> HIVE-18622.05.patch, HIVE-18622.06.patch, HIVE-18622.07.patch,
> HIVE-18622.08.patch, HIVE-18622.09.patch, HIVE-18622.091.patch,
> HIVE-18622.092.patch, HIVE-18622.093.patch, HIVE-18622.094.patch,
> HIVE-18622.095.patch, HIVE-18622.096.patch, HIVE-18622.097.patch,
> HIVE-18622.098.patch, HIVE-18622.099.patch
>
>
>
> Many vector expression classes are setting noNulls to true which does not
> work if the VRB is a scratch column being reused. The previous use may have
> set noNulls to false and the isNull array will have some rows marked as NULL.
> The result is wrong query results and sometimes NPEs (for BytesColumnVector).
> So, many vector expressions need this:
> {code:java}
> // Carefully handle NULLs...
> /*
> * For better performance on LONG/DOUBLE we don't want the conditional
> * statements inside the for loop.
> */
> outputColVector.noNulls = false;
> {code}
> And, vector expressions need to make sure the isNull array entry is set when
> outputColVector.noNulls is false.
> And, all place that assign column value need to set noNulls to false when the
> value is NULL.
> Almost all cases where noNulls is set to true are incorrect.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
