[ https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385457#comment-16385457 ]
Vineet Garg commented on HIVE-18746: ------------------------------------ Look good to me. +1 > add_months should validate the date first > ----------------------------------------- > > Key: HIVE-18746 > URL: https://issues.apache.org/jira/browse/HIVE-18746 > Project: Hive > Issue Type: Bug > Components: Hive > Reporter: Subhasis Gorai > Assignee: Kryvenko Igor > Priority: Minor > Attachments: HIVE-18746.1.patch, HIVE-18746.3.patch, > HIVE-18746.4.patch, HIVE-18746.5.patch, HIVE-18746.6.patch, > HIVE-18746.7.patch, HIVE-18746.patch > > > hive (sbg_hvc_ods)> select add_months('2017-02-28', 1); > OK > _c0 > 2017-03-31 > Time taken: 0.107 seconds, Fetched: 1 row(s) > hive (sbg_hvc_ods)> select add_months('2017-02-29', 1); > OK > _c0 > 2017-04-01 > Time taken: 0.084 seconds, Fetched: 1 row(s) > hive (sbg_hvc_ods)> > > '2017-02-29' is an invalid date. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)