[ 
https://issues.apache.org/jira/browse/HIVE-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388162#comment-16388162
 ] 

ASF GitHub Bot commented on HIVE-18864:
---------------------------------------

GitHub user sankarh opened a pull request:

    https://github.com/apache/hive/pull/316

    HIVE-18864: ValidWriteIdList snapshot seems incorrect if obtained after 
allocating writeId by current transaction.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sankarh/hive HIVE-18864

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hive/pull/316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #316
    
----
commit 85afddc2ab46d2f73f1ed7bcdb81105a30f7db8a
Author: Sankar Hariappan <mailtosankarh@...>
Date:   2018-03-06T17:20:50Z

    HIVE-18864: ValidWriteIdList snapshot seems incorrect if obtained after 
allocating writeId by current transaction.

----


> ValidWriteIdList snapshot seems incorrect if obtained after allocating 
> writeId by current transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-18864
>                 URL: https://issues.apache.org/jira/browse/HIVE-18864
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Sankar Hariappan
>            Assignee: Sankar Hariappan
>            Priority: Major
>              Labels: ACID, pull-request-available
>             Fix For: 3.0.0
>
>         Attachments: HIVE-18864.01.patch
>
>
> For multi-statement txns, it is possible that write on a table happens after 
> a read. Let's see the below scenario.
>  # Committed txn=9 writes on table T1 with writeId=5.
>  # Open txn=10. ValidTxnList(open:null, txn_HWM=10),
>  # Read table T1 from txn=10. ValidWriteIdList(open:null, write_HWM=5).
>  # Open txn=11, writes on table T1 with writeid=6.
>  # Read table T1 from txn=10. ValidWriteIdList(open:null, write_HWM=5).
>  # Write table T1 from txn=10 with writeId=7.
>  # Read table T1 from txn=10. {color:#d04437}*ValidWriteIdList(open:null, 
> write_HWM=7)*. – This read will able to see rows added by txn=11 which is 
> still open.{color}
> {color:#d04437}So, it is needed to rebuild the open/aborted list of 
> ValidWriteIdList based on txn_HWM. Any writeId allocated by txnId > txn_HWM 
> should be marked as open. In this example, *ValidWriteIdList(open:6, 
> write_HWM=7)* should be generated.{color}
> {color:#333333}cc{color} [~ekoifman], [~thejas]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to