[ 
https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393427#comment-16393427
 ] 

Sahil Takiar commented on HIVE-18883:
-------------------------------------

[~pvary] is there a good way to test this on Hive QA? I think the patch won't 
get applied until after it checks for {{FINDBUGS_HOME}}

{code}
============================================================================
============================================================================
                         Determining needed tests
============================================================================
============================================================================

(Depending upon input size and number of plug-ins, this may take a while)
...
============================================================================
============================================================================
                         Applying patch to master
============================================================================
============================================================================

Applying the patch:
Fri Mar  9 06:08:08 UTC 2018
cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9564
git apply --binary -v --stat --apply -p1 
/data/hiveptest/logs/PreCommit-HIVE-Build-9564/yetus/patch
{code}

I've tested this locally and it works.

> Add findbugs to yetus pre-commit checks
> ---------------------------------------
>
>                 Key: HIVE-18883
>                 URL: https://issues.apache.org/jira/browse/HIVE-18883
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>         Attachments: HIVE-18883.1.patch, HIVE-18883.2.patch
>
>
> We should enable FindBugs for our YETUS pre-commit checks, this will help 
> overall code quality and should decrease the overall number of bugs in Hive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to