[
https://issues.apache.org/jira/browse/HIVE-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408726#comment-16408726
]
Eugene Koifman commented on HIVE-18751:
---------------------------------------
[~sankarh], should
{noformat}
// Pass the ValidTxnList and ValidTxnWriteIdList snapshot configurations
corresponding to the input query
HiveConf driverConf = driver.getConf();
String validTxnString = driverConf.get(ValidTxnList.VALID_TXNS_KEY);
if (validTxnString != null) {
jc.set(ValidTxnList.VALID_TXNS_KEY, validTxnString);
}
String validWriteIdString =
driverConf.get(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY);
if (validWriteIdString != null) {
jc.set(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY,
validWriteIdString);
}
{noformat}
do some sort of check to make sure that this value was set as expected?
this patch crossed with HIVE-18825 and could've caused a really bad bug I think
> ACID table scan through get_splits UDF doesn't receive ValidWriteIdList
> configuration.
> --------------------------------------------------------------------------------------
>
> Key: HIVE-18751
> URL: https://issues.apache.org/jira/browse/HIVE-18751
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
> Affects Versions: 3.0.0
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Priority: Major
> Labels: ACID, UDF, pull-request-available
> Fix For: 3.0.0
>
> Attachments: HIVE-18751.01.patch
>
>
> Per table write ID (HIVE-18192) have replaced global transaction ID with
> write ID to version data files in ACID/MM tables,
> To ensure snapshot isolation, need to generate ValidWriteIdList for the given
> txn/table and use it when scan the ACID/MM tables.
> In case of get_splits UDF which runs on ACID table scan query won't receive
> it properly through configuration (hive.txn.tables.valid.writeids) and hence
> throws exception.
> TestAcidOnTez.testGetSplitsLocks is the test failing for the same. Need to
> fix it.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
