[ https://issues.apache.org/jira/browse/HIVE-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422184#comment-16422184 ]
Ankit Singhal commented on HIVE-18873: -------------------------------------- bq. Sorry for lagging behind on this one. Patch looks good to me. +1, pending tests. Thanks [~prasanth_j], It seems test failures are not related to this, can we have this committed now? > Skipping predicate pushdown for MR silently at HiveInputFormat can cause > storage handlers to produce erroneous result > --------------------------------------------------------------------------------------------------------------------- > > Key: HIVE-18873 > URL: https://issues.apache.org/jira/browse/HIVE-18873 > Project: Hive > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Ankit Singhal > Assignee: Ankit Singhal > Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18873.patch > > > {code:java} > // disable filter pushdown for mapreduce when there are more than one table > aliases, > // since we don't clone jobConf per alias > if (mrwork != null && mrwork.getAliases() != null && > mrwork.getAliases().size() > 1 && > jobConf.get(ConfVars.HIVE_EXECUTION_ENGINE.varname).equals("mr")) { > return; > } > {code} > I believe this needs to be handled at OpProcFactory so that hive doesn't > believe that predicate is handled by storage handler. -- This message was sent by Atlassian JIRA (v7.6.3#76005)